IFSC Website #32
Open
IFSC Website #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patlola
reviewed
Feb 27, 2019
| </tr> | ||
| <tr> | ||
| <th>Contact</th> | ||
| <td><%= data['CONTACT']%></td> |
There was a problem hiding this comment.
some of the data is null and it's not sanitized properly.
There was a problem hiding this comment.
Yeah, design is WIP for now.
| @@ -0,0 +1 @@ | |||
| Sitemap: https://ifsc.stage.razorpay.in/sitemap.xml.gz | |||
There was a problem hiding this comment.
put the prod url. until we submit the sitemap, search engines will not crawl i guess
| d.delete_if { |key| %w[BANK IFSC].include? key } | ||
| redis.hmset ifsc, *d | ||
| # CHANGE TO .com before merging | ||
| SitemapGenerator::Sitemap.default_host = 'https://ifsc.stage.razorpay.in' |
There was a problem hiding this comment.
get it from config may be?
| if data['BANK'] && data['BRANCH'] | ||
| url = "/#{data['BANK'].to_s.to_slug}/#{data['BRANCH'].to_s.to_slug}/#{ifsc}" | ||
| end | ||
| if url |
| </tr> | ||
| <tr> | ||
| <th>Address</th> | ||
| <td><%= data['ADDRESS']%></td> |
There was a problem hiding this comment.
also, add https://schema.org/ context schema so that search engines recognize the data easily
added 10 commits
January 28, 2021 13:32
- Adds a PINCODE attribute as well
captn3m0
force-pushed
the
ifsc-website
branch
from
6af02f0
to
9365741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instructions:
Then open one of these in the browser:
TODO:
/banks/:codedoesn't seem to