[util] remove pygloo support #46590
[util] remove pygloo support #46590
Conversation
aslonnie
force-pushed
the
lonnie-270711-nogloo
branch
from
000ab7e
to
9669ca8
Compare
pygloo support stops at python 3.8, which ray does not support. the pygloo package is effectively already dead Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
force-pushed
the
lonnie-270711-nogloo
branch
from
9669ca8
to
a1a03eb
Compare
|
(jiajun the great can review everything..) |
|
@jovany-wang is https://github.com/ray-project/pygloo still maintained? I saw you had a commit 2 months ago. If it's still maintained, it needs to support newer version of python. |
|
@jjyao Yes. We are still maintaining it. Do we still need it in Ray in some scenarios? |
|
@jovany-wang can you then make it support python versions 3.9+. The old versions are EOLed. |
|
@jjyao Sure. I'll tell you our plan later. |
|
For what it's worth, I have some use cases for the collective communication on CPU via pygloo, so I hope it doesn't get removed. I managed to get pygloo to build for Python 3.11 by just updating pybind11_bazel and pybind11 in the WORKSPACE file and updating setup.py. It appears to work fine. This seems like a few hours of work for someone more familiar with Bazel than I am, so I certainly hope that we don't just delete! |
aslonnie
changed the title
|
@terraflops1048576 Thanks for your feedback. |
|
Let me clarify that if it's worth to have, then we need make it work. |
do we have a timeline? new wheels (py39 310 311 312) need to be published on pypi. |
|
ping, any follow up? |
|
fwiw, there is no intersection on python version between ray release and gloo. when gloo starts catching up, we can always revert this change and add gloo back. |
|
Would sample wheels for Python 3.11 or a hacked together pygloo repository be helpful for updating? |
how would a ray user use it? why only 3.11? |
|
As in it's a pretty easy task to build for Python 3.11 (which is the Python that I regularly use for projects). It was a matter of changing the dependencies in the pygloo repository. The code almost all works fine with only minor tweaks. However, it looks like the maintainer hasn't gotten to it. I can probably build these wheels for all Python versions >= 3.9, but probably not for all platforms. |
|
any update? |
|
Hi, thanks. I will reply to you soon when I'm back.
|
any update? |
|
Hi, thanks. I will reply to you soon when I'm back.
|
and when is that? like is it okay to commit this change and revert this change when you are back and have progress? the python version that ray supports now has no intersection with pygloo. this code is effectively dead weight in the code base, and we have been waiting for 3 months. |
pygloo support stops at python 3.8, which ray does not support. the pygloo package is effectively already dead