Chaos

[SpheMakh]

No description provided.

[ratt-priv-ci]

Can one of the admins verify this patch?

[bennahugo]

ok to test

…

On Thu, Jun 6, 2024, 16:26 ratt-priv-ci ***@***.***> wrote: Can one of the admins verify this patch? — Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4RE6XM6DVTZXA5TH37OIDZGBWRHAVCNFSM6AAAAABI43J6A6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJSGY3TSMBRGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[SpheMakh]

Have these CI tests ever passed before?

[o-smirnov]

Passed for release I guess, but it's a little puzzling the failure now. Has the linter been improved or something? Are these legit errors it's picking up? Sorry, no time to look at the code today, but I can check on Monday.

[SpheMakh]

Yup, the errors are legit. But they are minor "undefined variable" type things that I can take care of.

[bennahugo]

Jenkins tests need to pass (and has been passing the monthly cronjob) - I test it against a full simulation and MT installation.

Current breakage:

Processing ./tigger-lsm
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'error'
�[91m  ERROR: Command errored out with exit status 1:
   command: /usr/bin/python3 /usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /tmp/tmpityetg7u
       cwd: /code/tigger-lsm
  Complete output (14 lines):
  Traceback (most recent call last):
    File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
      main()
    File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 164, in prepare_metadata_for_build_wheel
      return hook(metadata_directory, config_settings)
    File "/tmp/pip-build-env-z_qut63v/overlay/lib/python3.6/site-packages/poetry/core/masonry/api.py", line 43, in prepare_metadata_for_build_wheel
      poetry = Factory().create_poetry(Path(".").resolve(), with_dev=False)
    File "/tmp/pip-build-env-z_qut63v/overlay/lib/python3.6/site-packages/poetry/core/factory.py", line 43, in create_poetry
      raise RuntimeError("The Poetry configuration is invalid:\n" + message)
  RuntimeError: The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)

[SpheMakh]

I don't have access to the Jenkins test, but the tests in the .travis/py3.docker file are already done in the test_installation.yaml github action. The MeqTrees and Timba things do not belong here, so I would remove the travis test completely.

[SpheMakh]

Jenkins tests need to pass (and has been passing the monthly cronjob) - I test it against a full simulation and MT installation.

Current breakage:

Processing ./tigger-lsm
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'error'
�[91m  ERROR: Command errored out with exit status 1:
   command: /usr/bin/python3 /usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /tmp/tmpityetg7u
       cwd: /code/tigger-lsm
  Complete output (14 lines):
  Traceback (most recent call last):
    File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
      main()
    File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 164, in prepare_metadata_for_build_wheel
      return hook(metadata_directory, config_settings)
    File "/tmp/pip-build-env-z_qut63v/overlay/lib/python3.6/site-packages/poetry/core/masonry/api.py", line 43, in prepare_metadata_for_build_wheel
      poetry = Factory().create_poetry(Path(".").resolve(), with_dev=False)
    File "/tmp/pip-build-env-z_qut63v/overlay/lib/python3.6/site-packages/poetry/core/factory.py", line 43, in create_poetry
      raise RuntimeError("The Poetry configuration is invalid:\n" + message)
  RuntimeError: The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)

This test is uses a system with Python 3.6, which is not supported. The tests should be run on an appropriate environment.

[bennahugo]

I don't have access to the Jenkins test, but the tests in the .travis/py3.docker file are already done in the test_installation.yaml github action. The MeqTrees and Timba things do not belong here, so I would remove the travis test completely.

As far as I can see the test on GH only checks the very basic conversion scripts, not numerical accuracy (which is covered in the full simulation).

[SpheMakh]

I don't have access to the Jenkins test, but the tests in the .travis/py3.docker file are already done in the test_installation.yaml github action. The MeqTrees and Timba things do not belong here, so I would remove the travis test completely.

As far as I can see the test on GH only checks the very basic conversion scripts, not numerical accuracy (which is covered in the full simulation).

Noted. Let's keep it the tests, but please update the Python to a more recent version, say 3.10.

[bennahugo]

Can possibly base off this: https://github.com/ratt-ru/meqtrees-timba/blob/master/.ci/ubuntu22.04.docker

[SpheMakh]

Can possibly base off this: https://github.com/ratt-ru/meqtrees-timba/blob/master/.ci/ubuntu22.04.docker

Yup. Much better, I'll make the updates

[o-smirnov]

LGTM