Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply gains to autocorrelations when forming corrected data/residuals. #437

Merged
merged 5 commits into from
Aug 19, 2021

Conversation

JSKenyon
Copy link
Collaborator

@JSKenyon JSKenyon commented Feb 26, 2021

@bennahugo could you please test drive this? I have sanity checked it locally, but you may want to confirm that it is producing what you expect.

@JSKenyon
Copy link
Collaborator Author

retest this please

@JSKenyon
Copy link
Collaborator Author

Tests cannot pass at present. See this SO. I know we decided that python2.7 needed to burn, so should we remove that part of the tests?

@o-smirnov
Copy link
Collaborator

Yeah we were already going to drop it in #424 anyway. Which, BTW, really ought to get merged now. But let's do this one first!

@bennahugo
Copy link
Collaborator

bennahugo commented Feb 26, 2021 via email

@bennahugo
Copy link
Collaborator

As discussed this removes the OMT response but neither the Tsys contribution from Tlna or Tspil which are both correlated powers that are frequency dependent on these products @landmanbester. I don't see a reason not to at least remove the OMT response from them though? The other Tsys factors have to be determined by other means - ie on/off observation or another more complicated mechanism to block off the power from the horn in switching systems - these are in very old telescopes, but I don't know if they are actually still in use anywhere.

@bennahugo bennahugo merged commit c891eeb into master Aug 19, 2021
@bennahugo bennahugo deleted the issue-436 branch August 19, 2021 14:39
bennahugo added a commit that referenced this pull request Aug 20, 2021
* bump dependencies to ddf 0.6.0

* fixes #434

* Fixes #422

* Fixes #455

* Fixes bug introduced by merge of #437 

* Cleans up logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants