-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply gains to autocorrelations when forming corrected data/residuals. #437
Conversation
retest this please |
Tests cannot pass at present. See this SO. I know we decided that python2.7 needed to burn, so should we remove that part of the tests? |
Yeah we were already going to drop it in #424 anyway. Which, BTW, really ought to get merged now. But let's do this one first! |
Sure I will try it next week - a bit swamped monitoring the current science
observations. Thanks Jon.
…On Fri, 26 Feb 2021, 12:29 Oleg Smirnov, ***@***.***> wrote:
Yeah we were already going to drop it in #424
<#424> anyway. Which, BTW, really
ought to get merged now. But let's do this one first!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#437 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4RE6T2T2ES7XWBMQ5LEZ3TA5ZYPANCNFSM4YIAVW4A>
.
|
As discussed this removes the OMT response but neither the Tsys contribution from Tlna or Tspil which are both correlated powers that are frequency dependent on these products @landmanbester. I don't see a reason not to at least remove the OMT response from them though? The other Tsys factors have to be determined by other means - ie on/off observation or another more complicated mechanism to block off the power from the horn in switching systems - these are in very old telescopes, but I don't know if they are actually still in use anywhere. |
@bennahugo could you please test drive this? I have sanity checked it locally, but you may want to confirm that it is producing what you expect.