Fix panels not disposed if loading of settings failed

Signed-off-by: paulober <[email protected]>
raspberrypi · Sep 11, 2024 · 92cfd4f · 92cfd4f
1 parent 9b45bd3
commit 92cfd4f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/webview/newMicroPythonProjectPanel.mts b/src/webview/newMicroPythonProjectPanel.mts
@@ -75,6 +75,8 @@ export class NewMicroPythonProjectPanel {
 
     const settings = Settings.getInstance();
     if (!settings) {
+      panel.dispose();
+
       // TODO: maybe add restart button
       void window.showErrorMessage(
         "Failed to load settings. Please restart VSCode."

diff --git a/src/webview/newProjectPanel.mts b/src/webview/newProjectPanel.mts
@@ -382,6 +382,8 @@ export class NewProjectPanel {
 
     const settings = Settings.getInstance();
     if (settings === undefined) {
+      panel.dispose();
+
       // TODO: maybe add restart button
       void window.showErrorMessage(
         "Failed to load settings. Please restart VSCode."