feat: display same source and destination token warning on widget #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,8 @@ export function NoResult(props: PropTypes) { | |||
| fetch | |||
| ); | |||
|
|
|||
| console.log(info); | |||
| @@ -107,7 +105,14 @@ export function useSwapInput({ | |||
| affiliatePercent, | |||
| affiliateWallets, | |||
| } = params; | |||
| if (areTokensEqual(fromToken, toToken)) { | |||
| console.log('....'); | |||
|
In the current implementation, the warning appears after the debounce period for the input. If the user changes the input, the warning will be cleared and then reappear after the debounce delay. I suggest leaving the existing logic for the quote unchanged and simply adding a check and warning for this specific state in the relevant component, so the warning displays immediately without delay. |
mikasackermn
force-pushed
the
feat/rf-1913-same-tokens-warning
branch
from
5a19776
to
346c93e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the source and destination tokens are selected as the same, we should show a warning to the user.
Fixes # (issue)
How did you test this change?
Select the same token for both the source and destination, and also enter an amount
Checklist: