feat: add routing parameters to widget config #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikasackermn
force-pushed
the
feat/rf-1971-add-routing-params
branch
from
86a887d
to
3851e15
Compare
mikasackermn
force-pushed
the
feat/rf-1971-add-routing-params
branch
2 times, most recently
from
f4e678e
to
31b6ca9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nikaaru
reviewed
Nov 12, 2024
RanGojo
reviewed
Nov 12, 2024
mikasackermn
force-pushed
the
feat/rf-1971-add-routing-params
branch
from
cddaf9f
to
91afdf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We needed to add
avoidNativeFeeandmaxLengthto features, but after speaking with @RanGojo and @yeager-eren, we concluded that we should create a new parameter calledrouting. This parameter will containavoidNativeFee,maxLength, andexperimental.