Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add extract translations job to check workflow #892

Merged

Conversation

RyukTheCoder
Copy link
Collaborator

@RyukTheCoder RyukTheCoder commented Oct 6, 2024

Summary

Added extract translations job to check workflow. Also added a wrapper on extract translations in check workflow to exit if there is an error in extract flow which does not force workflow to fail.

Fixes # 1873

How did you test this change?

Ran Github workflow.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@RanGojo
Copy link
Member

RanGojo commented Oct 16, 2024

Please check @nikaaru this

Copy link
Member

@nikaaru nikaaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyukTheCoder RyukTheCoder force-pushed the chore/rf-1873-add-extract-translations-job-to-check-workflow branch from 8f5ebe5 to 3978165 Compare October 20, 2024 00:34
@nikaaru nikaaru merged commit 5ce4873 into next Nov 3, 2024
5 checks passed
@nikaaru nikaaru deleted the chore/rf-1873-add-extract-translations-job-to-check-workflow branch November 3, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants