feat: support starknet snap for metamask #450
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanGojo
reviewed
Dec 6, 2023
Comment on lines
+1
to
+13
| # [0.14.0](https://github.com/rango-exchange/rango-client/compare/[email protected]@0.14.0) (2023-08-03) | ||
|
|
||
|
|
||
|
|
||
| # [0.13.0](https://github.com/rango-exchange/rango-client/compare/[email protected]@0.13.0) (2023-08-01) | ||
|
|
||
|
|
||
|
|
||
| # [0.9.0](https://github.com/rango-exchange/rango-client/compare/[email protected]@0.9.0) (2023-07-31) | ||
|
|
||
|
|
||
|
|
||
| # [0.7.0](https://github.com/rango-exchange/rango-client/compare/[email protected]@0.7.0) (2023-07-11) |
There was a problem hiding this comment.
please remove content of this file
| @@ -0,0 +1 @@ | |||
| # @rango-dev/provider-metamask | |||
| return accounts; | ||
| }; | ||
|
|
||
| export const subscribe: Subscribe = subscribeToEvm; |
|
|
||
| export const getSigners: (provider: any) => SignerFactory = signer; | ||
|
|
||
| export const canEagerConnect: CanEagerConnect = canEagerlyConnectToEvm; |
| const starknet = starknetBlockchain(allBlockChains); | ||
| return { | ||
| name: 'Starknet Snap', | ||
| img: 'https://raw.githubusercontent.com/rango-exchange/assets/main/wallets/metamask/icon.svg', |
There was a problem hiding this comment.
we need another icon from design team.
Comment on lines
+25
to
+48
| try { | ||
| for (const call of calls) { | ||
| const res = await sendTransaction( | ||
| this.provider, | ||
| call.contractAddress, | ||
| call.entrypoint, | ||
| (call.calldata as string[]).toString(), | ||
| address, | ||
| chainId | ||
| ); | ||
| console.log({ res }); | ||
| } | ||
|
|
||
| return { hash: '' }; | ||
| } catch (err) { | ||
| console.log({ err }); | ||
|
|
||
| if (SignerError.isSignerError(err)) { | ||
| throw err; | ||
| } else { | ||
| throw new SignerError(SignerErrorCode.SEND_TX_ERROR, undefined, err); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
we need to update this code to handle multiple calls once we have access to starkNet_executeTxn.
Consensys/starknet-snap#181
RanGojo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Starknet snap allows developers to deploy Starknet accounts, make transactions on Starknet, and interact with Starknet smart contracts. We have to implement it in the providers.
How did you test this change?
You can test this by running the widget and connecting to Starknet Snap and swap in Blockchain Starknet
Checklist: