feat(wallets): make wallet provider blockchains prop optional #345
Conversation
There was a problem hiding this comment.
I've put my comments on your approach but I'm against to make the wallets-react dependent on rango-chains.
First, If we are adding rango-chains to react, it should be added to core since it can be used separately as well.
Second and the main one, our wallets already support for passing the list of blockchains so the library user should pass the data and use rango-chains if the user want. (For our use case it should be on embedded)
| import type { ProviderContext, ProviderProps } from './types'; | ||
| import type { WalletType } from '@rango-dev/wallets-shared'; | ||
|
|
||
| import { allSupportedBlockchains } from 'rango-chains'; |
There was a problem hiding this comment.
Dependency hasn't been added to package.json
| props.allBlockChains.length && | ||
| props.autoConnect && | ||
| !autoConnectInitiated.current; | ||
| // props.allBlockChains && |
| } from './rango'; | ||
| import type { | ||
| StdBlockchainInfo, |
There was a problem hiding this comment.
This comment should be written on rango-types, but as we talked I will put it here.
Is there any standard for what we need here? or it's only our convention and how we structure the code?
if there is no actual standard, I suggest to don't use Std prefix since std can be misleading for people.
BlockchainInfo would works for what we do here.
RanGojo
requested review from
mikasackermn,
Ikari-Shinji-re and
samobasquiat
as code owners
No description provided.