Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widescreen HUD Hack Patch for Echoes #108

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Nystrata
Copy link

@Nystrata Nystrata commented Jul 27, 2024

Leaving this as a draft for now because this will depend on other PRs for other repositories and there's likely a lot to be tested and change

What this does:

  • Via a dol patch, Render the game in 16:9 (ported from gamemasterplc's ntsc 16:9 gecko code)
  • Via provided edited FRMEs from my widescreenhud mod, adjust the HUD/Visor widgets to better match the 16:9 aspect ratio
  • For FRME replacement, there is a new schema entry for Widescreen Patch
    For DOL patches, new entry in EchoesDolPatchesData
  • This works for both NTSC-U and PAL versions of the game. (I ported gmplc's code to PAL)

To-Do

  • Done! Open PR for the other repos
  • This still requires a lot of testing. I found empty space in memory, but I don't have a good way to make sure that it doesn't cause issues.

Screenshot 2024-07-27 150003

@Nystrata Nystrata marked this pull request as ready for review October 12, 2024 14:57
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (e5a6377) to head (ac0461b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...open_prime_rando/echoes/widescreen_hud/__init__.py 26.31% 14 Missing ⚠️
...pen_prime_rando/dol_patching/echoes/dol_patches.py 81.81% 4 Missing ⚠️
src/open_prime_rando/echoes_patcher.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   87.42%   86.72%   -0.71%     
==========================================
  Files          41       43       +2     
  Lines        1782     1830      +48     
==========================================
+ Hits         1558     1587      +29     
- Misses        224      243      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nystrata
Copy link
Author

I think, at this stage, it's ready to go as is

Future plans do involve stubbing out DrawWidescreen:

  • It'll get rid of the black bars in some cutscenes (thought, it doesn't get all of them, so I have to research how to hide the blackbars in other cutscenes)
  • It'll give me space in the DOL to store the extra PPC, instead of finding random and possibly unreliable unused empty space.

However, I'm holding off of this until the patcher can get a fresh vanilla dol each time, since I don't think there's a good way to restore vanilla behavior when the options is turned off in RDV.

@Nystrata Nystrata changed the title Widescreen HUD Hack Patch Widescreen HUD Hack Patch for Echoes Oct 26, 2024
@Miepee Miepee requested review from henriquegemignani and duncathan and removed request for henriquegemignani October 28, 2024 13:13
@Miepee Miepee disabled auto-merge October 30, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants