Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write pkgs with only ensured assets #89

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ThanatosGit
Copy link
Contributor

In save_modifications MEDS is creating a modified_pkgs set but it only adds a pkg to the set, if you have modified ressources or have added ressources to it but not if you only have used the ensure_present method. The last method only adds it to _ensured_asset_ids, so it is reasonable to iterate through it and add these pkgs.

This is relevant for MSR as it has a AREA_NAME.pkg but also a AREA_NAME_discardables.pkg. In the first one we ensure all the models, animations etc., while the second contains the scenario BRFLD, lua files and BMSAD.

Let's hope that nothing breaks for Dread (but we are using RomFS export anyways now?)

@henriquegemignani henriquegemignani added this pull request to the merge queue Oct 23, 2023
Merged via the queue into randovania:main with commit 87ab147 Oct 23, 2023
8 checks passed
@ThanatosGit ThanatosGit deleted the write-pkgs-fix branch October 23, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants