Write pkgs with only ensured assets #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
save_modifications
MEDS is creating amodified_pkgs
set but it only adds a pkg to the set, if you have modified ressources or have added ressources to it but not if you only have used theensure_present
method. The last method only adds it to_ensured_asset_ids
, so it is reasonable to iterate through it and add these pkgs.This is relevant for MSR as it has a
AREA_NAME.pkg
but also aAREA_NAME_discardables.pkg
. In the first one we ensure all the models, animations etc., while the second contains the scenario BRFLD, lua files and BMSAD.Let's hope that nothing breaks for Dread (but we are using RomFS export anyways now?)