Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bmsbk field #82

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Rename bmsbk field #82

merged 2 commits into from
Sep 24, 2023

Conversation

ThanatosGit
Copy link
Contributor

According to DCR unk4 is the respawn time for the blocks, where 0.0 means it nevers respawn and if greater than 0.0 it's the time in seconds.

@dyceron Are there other fields we could rename? There was a "always visible" thing but I don't know to which field it was related.

@dyceron
Copy link
Contributor

dyceron commented Sep 23, 2023

Thats all I saw at the moment. unk3 controls the always visible part, though it's not perfect

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9e15a56) 73.41% compared to head (25ce7aa) 73.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   73.41%   73.41%           
=======================================
  Files          58       58           
  Lines        3062     3062           
=======================================
  Hits         2248     2248           
  Misses        814      814           
Files Changed Coverage Δ
...rc/mercury_engine_data_structures/formats/bmsbk.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThanatosGit ThanatosGit marked this pull request as ready for review September 24, 2023 07:43
@ThanatosGit ThanatosGit added this pull request to the merge queue Sep 24, 2023
Merged via the queue into randovania:main with commit 7f10a30 Sep 24, 2023
9 checks passed
@ThanatosGit ThanatosGit deleted the bmsbk-params branch September 24, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants