-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Add tests for BMSLD parse and build #77
Conversation
ThanatosGit
commented
Sep 12, 2023
- Add tests for BMSLD methods
- Add tests for BMSLD methods
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 72.17% 73.13% +0.95%
==========================================
Files 56 56
Lines 3030 3030
==========================================
+ Hits 2187 2216 +29
+ Misses 843 814 -29
☔ View full report in Codecov by Sentry. |
@@ -166,7 +166,7 @@ def get_actor_group(self, group_name: str) -> Container: | |||
None | |||
) | |||
if group is None: | |||
raise Exception(f"No group found with name for {group_name}") | |||
raise ValueError(f"No group found with name for {group_name}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I'd prob call this a KeyError, even if it isn't technically a dictionary. @henriquegemignani thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to KeyError now. Both are kinda matching / non-matching. It's not a dict but very similar lookup. Otherwise you could say, you just used a wrong value for the parameter.
(just forced push as the last two changes were pretty small)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a container-like enough for me.
719ae4e
to
bc3b413
Compare
bc3b413
to
bed95cd
Compare