update bmsad #62
Merged
update bmsad #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I gather that the one Dread test still fails? |
|
yeah that bmsad is like actually corrupt I'm pretty sure? I haven't checked in a while but I remember it being really broken |
dyceron
previously requested changes
Aug 18, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 69.10% 71.25% +2.15%
==========================================
Files 54 54
Lines 2544 2811 +267
==========================================
+ Hits 1758 2003 +245
- Misses 786 808 +22
☔ View full report in Codecov by Sentry. |
henriquegemignani
requested changes
Aug 18, 2023
|
|
||
|
|
||
| Argument = Struct( | ||
| ArgListDread = DictAdapter(make_vector(Struct( |
There was a problem hiding this comment.
Make a _arg_list function that creates the ArgListXX, since it only differs by the ArgTypes
There was a problem hiding this comment.
no, the value differs as well. SR has an explicit type field which dread lacks
- mostly just a simpler format of Dread's navmesh - geo_connections have 3 bytes added to the start of each entry - there's an unknown struct that seems to be there for metroids, probably similar to how emmy actions are in dread
more accurate for dread; complete for SR. SR bmsad embeds bmsas
for more information, see https://pre-commit.ci
duncathan
force-pushed
the
feature/bmsad
branch
from
be21b4c
to
8fc0ac6
Compare
steven11sjf
approved these changes
Aug 23, 2023
| @@ -111,6 +111,7 @@ def _emitbuild(self, code: construct.CodeGen): | |||
|
|
|||
| PropertyEnum = CRCAdapter(HashSet.PROPERTY) | |||
| PropertyEnumUnsafe = CRCAdapter(HashSet.PROPERTY, True) | |||
| PropertyEnumDoubleUnsafe = CRCAdapter(HashSet.PROPERTY, True, False) | |||
There was a problem hiding this comment.
Yeah I'm proud of this one ngl
henriquegemignani
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more accurate for dread; more complete for SR. SR bmsad embeds bmsas and i am miserable about it
this is a super breaking change for ODR and OSRR