Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress in BMSAD for SR #50

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Progress in BMSAD for SR #50

merged 6 commits into from
Aug 4, 2023

Conversation

henriquegemignani
Copy link
Member

@henriquegemignani henriquegemignani commented Aug 2, 2023

Depends on #52.

Except for two specific BMSAD, parses all components of all the other files.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.63% 🎉

Comparison is base (10435d3) 65.14% compared to head (ac5d129) 65.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   65.14%   65.78%   +0.63%     
==========================================
  Files          54       54              
  Lines        2324     2344      +20     
==========================================
+ Hits         1514     1542      +28     
+ Misses        810      802       -8     
Files Changed Coverage Δ
src/mercury_engine_data_structures/common_types.py 74.00% <100.00%> (+1.27%) ⬆️
...rc/mercury_engine_data_structures/formats/bmsad.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henriquegemignani henriquegemignani force-pushed the feature/bmsad-sr branch 2 times, most recently from ca9d6f5 to ae146b6 Compare August 4, 2023 14:28
Copy link
Contributor

@duncathan duncathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the runner to have a SAMUS_RETURNS_PATH for testing

@duncathan duncathan merged commit bba6e58 into main Aug 4, 2023
9 checks passed
@duncathan duncathan deleted the feature/bmsad-sr branch August 4, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants