Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff rules, use if TYPE_CHECKING/future annotations #233

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

henriquegemignani
Copy link
Member

No description provided.

@henriquegemignani henriquegemignani requested review from steven11sjf and a team October 14, 2024 07:43
@henriquegemignani henriquegemignani added the enhancement New feature or request label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 70.94340% with 77 lines in your changes missing coverage. Please review.

Project coverage is 75.53%. Comparing base (430c6ef) to head (d79c46d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...mercury_engine_data_structures/file_tree_editor.py 42.85% 4 Missing ⚠️
.../mercury_engine_data_structures/adapters/offset.py 0.00% 3 Missing ⚠️
...rc/mercury_engine_data_structures/base_resource.py 0.00% 3 Missing ⚠️
...ne_data_structures/construct_extensions/strings.py 25.00% 3 Missing ⚠️
...rc/mercury_engine_data_structures/formats/brfld.py 57.14% 3 Missing ⚠️
src/mercury_engine_data_structures/formats/brsa.py 62.50% 3 Missing ⚠️
src/mercury_engine_data_structures/romfs.py 50.00% 3 Missing ⚠️
src/mercury_engine_data_structures/formats/bapd.py 66.66% 2 Missing ⚠️
...c/mercury_engine_data_structures/formats/bgsnds.py 66.66% 2 Missing ⚠️
...rc/mercury_engine_data_structures/formats/bldef.py 66.66% 2 Missing ⚠️
... and 37 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   76.47%   75.53%   -0.95%     
==========================================
  Files          77       77              
  Lines        3532     3670     +138     
==========================================
+ Hits         2701     2772      +71     
- Misses        831      898      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henriquegemignani henriquegemignani added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit d41e7e7 Oct 15, 2024
9 of 11 checks passed
@henriquegemignani henriquegemignani deleted the feature/lazy-imports branch October 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants