Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with more info regarding mercury formats #215

Merged
merged 8 commits into from
Sep 8, 2024

Conversation

sabre230
Copy link
Contributor

Includes some notes to help parse what each type is for, as well as a little info on them that I have knowledge of.

README.md Outdated
| TOC | ✓ | ✓ | ✓ | ✓ |
| TXT | ✓ | ✓ | ✓ | ✓ |
| WEBM | Missing | Missing | ✗ | ✗ |
| Format | Samus Returns (Read) | Samus Returns (Write) | Dread (Read) | Dread (Write) | Samus Returns (Purpose) | Samus Returns (Notes) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these new columns are not specific to MSR. I'm also not sure the notes column is all that useful, at least for the MEDS readme. this is better suited for something like https://wiki.axiodl.com/ (but for MSE formats instead of retro)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, is there already a wiki for MSE formats?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There sadly is not :(

I'm also not sure the notes column is all that useful, at least for the MEDS readme

I know Henrique has asked in the past explicitly for it to get added. IMO, having a very quick description of what the general format is about (especially while we dont have a wiki yet), helps non-familiar people to know on a quick glance what is actually supported. Telling them "bcmdl and bctex aren't supported, but bmsnd are" is way less helpful for them than "models and textures arent supported, but sounds are".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also because I haven't made it clear before: I do think the "notes" section is useless and should be removed. Having a quick one-liner on "purpose" is more than enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly fine with a quick blurb, though that could just be the purpose. We could have a wiki in this repository for more details on each format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for a wiki in the git repo. Would love to see a main hub for modders to be able to grab pertinent information from.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have a wiki, but IMO the workflow for wikis in git repos is kinda meh.
AFAIK it only allows editing from either owners or everyone (latter is bad because of vandalism, former is bad because admittedly we're all lazy), and major search engines either still dont crawl it or used to not crawl it.
I have a draft wiki locally that i have never pushed anywhere, mostly because i have no clue on most of the file formats and would rather have something filled out before I push it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend something like MediaWiki, however that requires someone host it on a server, be it local or remote. The real benefit to Github's wiki format is that it doesn't need to be hosted by any one person. But the downsides are as you mentioned, more room for vandalism and upkeep issues. But I can confirm I've found github wikis from googling things before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunc already posted antidote's mediawiki above, we could probably discuss with him to host a mercury styled one instead.
but i personally dont like mediawiki that much because it also makes submitting changes harder, is harder to get themed (i very much value dark mode), and AFAIK is harder to write content for as you cant just use markdown.

My local-wiki-like-thing is using hugo, which i've always found more comfortable to work with. It also doesnt require someone to host it, as we can just host it off of github pages since it'd be a static website.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Incorporated changes from PR
@sabre230
Copy link
Contributor Author

Made revisions based on feedback.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Updated with changes requested from reviews
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
| BFSTM | Missing | Missing | ✗ | ✗ | |
| BGSNDS | Missing | Missing | ✓ | ✓ | |
| BLDEF | Missing | Missing | ✓ | ✓ | |
| BLSND | ✓ | ✓ | ✓ | ✓ | Sound |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just "sound" sounds too vague. sound effects? sound files? if sound file, whatd make it different from bcwav/bfstm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question! I'd write it down if I knew. :P

README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 36 to 37
| BMSEM | ✓ | ✓ | Missing | Missing | Environment Data |
| BMSES | ✓ | ✓ | Missing | Missing | Environment Data |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I was told both are for environmental data but didn't get much info on the differences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iirc EM is Environment Music, and ES is Environment Sound/SFX

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Environmental Sound

| BMSMD | ✓ | ✓ | Missing | Missing | Menu Data (?) |
| BMSMSD | ✓ | ✓ | Missing | Missing | Map Screen Data (?) |
| BMSNAV | ✓ | ✓ | ✓ | ✓ | Navigation Meshes |
| BMSND | ✗ | ✗ | Missing | Missing | Sound (?) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see sound comment above.

README.md Outdated
| BMSSK | Missing | Missing | ✓ | ✓ | |
| BMSSS | Missing | Missing | ✓ | ✓ | |
| BMSSTOC | Missing | Missing | ✗ | ✗ | |
| BMTRE | ✗ | ✗ | ✓ | ✓ | TRE (?) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im pretty sure other people know what this is. @steven11sjf at least fixed smoethingr egarding this recently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior Tree (entity AI)

README.md Outdated Show resolved Hide resolved
sabre230 and others added 2 commits August 28, 2024 14:21
"Collision Data, Geometry" to "Collision Data/Geometry"

Co-authored-by: Miepee <[email protected]>
Updated with suggestions from reviews
Copy link
Contributor

@steven11sjf steven11sjf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot but most of it is just adding dread stuff. there are a few SR things noted though.

README.md Outdated
| WEBM | Missing | Missing | &cross; | &cross; |
| Format | Samus Returns (Read) | Samus Returns (Write) | Dread (Read) | Dread (Write) | Purpose |
|-----------|----------------------|-----------------------|--------------|---------------|-------------|
| BAPD | Missing | Missing | &check; | &check; | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audio Preset (positional audio data)

README.md Outdated
| BCURV | Missing | Missing | &cross; | &cross; | |
| BCUT | &cross; | &cross; | Missing | Missing | Related to cutscene files |
| BCWAV | &cross; | &cross; | Missing | Missing | Common 3DS audio format |
| BFGRP | Missing | Missing | &cross; | &cross; | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound WaveGroup (Common AAL audio format)

README.md Outdated
| BCTEX | &cross; | &cross; | &check; | &cross; | Texture File |
| BCURV | Missing | Missing | &cross; | &cross; | |
| BCUT | &cross; | &cross; | Missing | Missing | Related to cutscene files |
| BCWAV | &cross; | &cross; | Missing | Missing | Common 3DS audio format |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cafe/Citra Wave (Common AAL audio format)

README.md Outdated
| BCCAM | &cross; | &cross; | &cross; | &cross; | Camera Objects |
| BCLGT | &cross; | &cross; | Missing | Missing | Lighting (?) |
| BCMDL | &cross; | &cross; | &check; | &cross; | 3D Models |
| BCPTL | &cross; | &cross; | &cross; | &cross; | PTL (?) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Particle Effect

README.md Outdated
| Format | Samus Returns (Read) | Samus Returns (Write) | Dread (Read) | Dread (Write) | Purpose |
|-----------|----------------------|-----------------------|--------------|---------------|-------------|
| BAPD | Missing | Missing | &check; | &check; | |
| BCCAM | &cross; | &cross; | &cross; | &cross; | Camera Objects |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to mention that it's used exclusively for a "shot" in a cutscene (afaik)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shot? Like another camera angle? Or a one-off used in some cutscene?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort of? it's like a shot in a film, where the camera can move, rotate, etc but it's not jumping between positions.

looking at this, the first shot runs to about 2:50, the second goes to 2:57, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poking around the other cutscene files it calls them "takes" which should probably be used instead

Copy link
Contributor Author

@sabre230 sabre230 Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's just there to handle when the camera angle changes and what it should be doing, exclusively in cutscenes. Is that right?

CutScene Cam?

README.md Outdated
| BSMAT | Missing | Missing | &check; | &check; | |
| BTUNDA | Missing | Missing | &check; | &check; | |
| BUCT | &check; | &check; | &check; | &check; | Font File (?) |
| INI | Missing | Missing | &check; | &check; | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard INI format

README.md Outdated
| PKG | &check; | &check; | &check; | &check; | Packaged Files |
| TOC | &check; | &check; | &check; | &check; | Table of Contents |
| TXT | &check; | &check; | &check; | &check; | Text File |
| WEBM | Missing | Missing | &cross; | &cross; | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard WEBM format

README.md Outdated
| LC | &check; | &check; | &check; | &check; | Lua Bytecode|
| PKG | &check; | &check; | &check; | &check; | Packaged Files |
| TOC | &check; | &check; | &check; | &check; | Table of Contents |
| TXT | &check; | &check; | &check; | &check; | Text File |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTF-16 Text File

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not quite true. TXT uses multiple encodings and follows a specific structure

README.md Show resolved Hide resolved
README.md Outdated
| BMSEM | &check; | &check; | Missing | Missing | Environment Data |
| BMSES | &check; | &check; | Missing | Missing | Environment Data |
| BMSEV | &cross; | &cross; | Missing | Missing | EV (?) |
| BMSLD | &check; | &check; | Missing | Missing | Level Data |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samus Returns scenario entity data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fills up just about all the gaps, thank you so much! ❤️ I've made another commit with those changes.

Added in all the information provided by steven11sjf (tyvm!)
README.md Outdated


## Example Usage

```python
# TODO
# TODOBMTRE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a typo on my part, my b.

README.md Outdated
| BFSAR | Missing | Missing | &cross; | &cross; | FSAR (?) |
| BFSTM | Missing | Missing | &cross; | &cross; | Common Switch audio format |
| BGSNDS | Missing | Missing | &check; | &check; | BackGround Sounds (?) |
| BLDEF | Missing | Missing | &check; | &check; | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actor Lighting Definition

README.md Outdated
| Format | Samus Returns (Read) | Samus Returns (Write) | Dread (Read) | Dread (Write) | Purpose |
|-----------|----------------------|-----------------------|--------------|---------------|-------------|
| BAPD | Missing | Missing | &check; | &check; | Audio Preset (positional audio data) |
| BCCAM | &cross; | &cross; | &cross; | &cross; | Cutscene Camera (used exclusively for cutscene takes) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "camera animation" instead of "cutscene camera"

README.md Outdated
| BLDEF | Missing | Missing | &check; | &check; | |
| BLSND | &check; | &check; | &check; | &check; | Sounds (?) |
| BLUT | Missing | Missing | &check; | &check; | LookUp Table (used for ADAM animation) |
| BMBLS | Missing | Missing | &check; | &check; | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blend Space

fixed typo, added suggested revisions
@Miepee Miepee changed the title Update README with more info regarding MSR types Update README with more info regarding mercury formats Aug 29, 2024
@ThanatosGit
Copy link
Contributor

I'm not gonna scroll through 90+ messages...is this the only thing left? #215 (comment)

Copy link
Member

@henriquegemignani henriquegemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so this doesn't get lost forever, I'll merge this. I think it'll work better if we review the result and make issues of what's wrong.

@henriquegemignani henriquegemignani added this pull request to the merge queue Sep 8, 2024
Merged via the queue into randovania:main with commit c7b1d2b Sep 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants