Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli commands for extract pkgs and replacing files in pkgs #214

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

henriquegemignani
Copy link
Member

No description provided.

@henriquegemignani henriquegemignani requested a review from a team August 28, 2024 19:25
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 76.24%. Comparing base (c389ebc) to head (f47c015).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/mercury_engine_data_structures/cli.py 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   76.98%   76.24%   -0.75%     
==========================================
  Files          76       76              
  Lines        3494     3528      +34     
==========================================
  Hits         2690     2690              
- Misses        804      838      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThanatosGit
Copy link
Contributor

If it's going to be part of the cli, is there any reason to keep tools/extract_pkg.py?

@henriquegemignani
Copy link
Member Author

Not really, but I'd rather delete it later. It does weird shenanigans with custom names and whatever that I'm not sure works, plus it's pretty spread that it exists so let people use what they know.

@ThanatosGit ThanatosGit added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 8f54c95 Aug 29, 2024
8 of 10 checks passed
@ThanatosGit ThanatosGit deleted the feature/new-cli-tools branch August 29, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants