BUCT #199
Merged
BUCT #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncathan
requested changes
Jul 27, 2024
| BUCT = Struct( | ||
| _magic = Const(b"MUCT"), | ||
| _is_sr = Computed(game_check.current_game_at_most(game_check.Game.SAMUS_RETURNS)), | ||
| version = IfThenElse( |
There was a problem hiding this comment.
game_check.is_sr_or_else() is a function that exists
| ), | ||
| size = Rebuild(Int32ul, construct.len_(construct.this.data)), | ||
| _padding = If(lambda ctx: not ctx._is_sr, Const(0xFFFFFFFF, Int32ul)), | ||
| _data_start = IfThenElse( |
There was a problem hiding this comment.
actually this one could probably just be a Pointer?
| VersionAdapter("1.4.0") | ||
| ), | ||
| size = Rebuild(Int32ul, construct.len_(construct.this.data)), | ||
| _padding = If(lambda ctx: not ctx._is_sr, Const(0xFFFFFFFF, Int32ul)), |
There was a problem hiding this comment.
If(current_game_at_least(Game.DREAD), Const(0xFFFFFFFF, Int32ul))
| data=Array(construct.this.size, Struct( | ||
| char_maybe = Int16ul, # I think this could be utf8 chars? | ||
| _padding = IfThenElse( | ||
| lambda ctx: ctx._._is_sr, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 76.69% 76.91% +0.21%
==========================================
Files 74 75 +1
Lines 3446 3457 +11
==========================================
+ Hits 2643 2659 +16
+ Misses 803 798 -5 ☔ View full report in Codecov by Sentry. |
- uses correct game_check functions - no longer caches whether the file is sr
duncathan
approved these changes
Aug 3, 2024
| ), | ||
| size = Rebuild(Int32ul, construct.len_(construct.this.data)), | ||
| _padding = If(lambda ctx: not ctx._is_sr, Const(0xFFFFFFFF, Int32ul)), | ||
| _data_start = IfThenElse( |
There was a problem hiding this comment.
actually this one could probably just be a Pointer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #170