Added bnvib #196
Merged
Added bnvib #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- standard NX library format, already documented online
Miepee
reviewed
Jul 27, 2024
| LOOP = 12 | ||
| LOOPWAIT = 16 | ||
|
|
||
| BNVIB = Struct( |
There was a problem hiding this comment.
would be nice to have a link to the switchbrew wiki page here.
Miepee
reviewed
Jul 27, 2024
Miepee
approved these changes
Jul 27, 2024
duncathan
reviewed
Jul 27, 2024
| "loop_start" / If(construct.this.vibration_type != VibrationType.NORMAL, Int32ul), | ||
| "loop_end" / If(construct.this.vibration_type != VibrationType.NORMAL, Int32ul), | ||
| "loop_wait" / If(construct.this.vibration_type == VibrationType.LOOPWAIT, Int32ul), | ||
| "data" / PrefixedArray(Int32ul, Byte) |
There was a problem hiding this comment.
Prefixed(Int32ul, GreedyBytes)
There was a problem hiding this comment.
actually looking at the documentation more closely: "The size of a sample is 4 bytes."
this should be Prefixed(Int32ul, GreedyRange(Int32ul))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard NX library format, already documented online https://switchbrew.org/wiki/BNVIB#Normal_Vibration