Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version adapter and test fixes #186

Merged
merged 8 commits into from
Jul 22, 2024

Commits on Jul 20, 2024

  1. Added version adapter

    - new adapter added to common_types that can read a version number, and
      optionally validate it against an integer, string or tuple(int, int,
      int)
    - applied this to all formats using version strings
    - fixed a bug where standard_format.game_model would ignore the name and
      version passed to it
    - fixed a bug where the bmssd tests wouldn't run
    steven11sjf committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    d715255 View commit details
    Browse the repository at this point in the history
  2. test overhaul

    - added parse/build of dread .bmdefs (standard format)
    - added functions to dread_data and samus_returns_data to get a list of
      all files ending in an extension
    - applied this change to all tests that were using list comp to do this
      already
    - fixed some tests that were only testing a subset of the total files
    steven11sjf committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    9adc56f View commit details
    Browse the repository at this point in the history
  3. cleaned up some testing functions

    - removed test_lib functions that operate on only files, since the
      FileTreeEditor can handle these
    - added  a parse_build_compare_editor_parsed function that compares a
      parsed file to its rebuilt and reparsed contents
    - added/simplified some checks to skip missing files
    steven11sjf committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    727a9ec View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dbc8554 View commit details
    Browse the repository at this point in the history
  5. ruff

    steven11sjf committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    45c319b View commit details
    Browse the repository at this point in the history
  6. added missing files to test files

    - files are now checked against a list of files expected to be missing
      before a test is skipped
    - removed a duplicate bmmap test and changed test_minimap.py to
      test_bmmdef.py
    - test_pkg retains old behavior of not using FileTreeEditor
    steven11sjf committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    2e843a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Missing files are no longer tested

    - added an optional list[str] arg "exclusions" to
      all_files_ending_with
    - parametrized test args now use this field to exclude missing files
      from parametrization, resulting in no skipped tests
    steven11sjf committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    cdd84c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0e1b68 View commit details
    Browse the repository at this point in the history