fixed potential circular imports in formats #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steven11sjf
commented
Jul 15, 2024
steven11sjf
commented
- replaced "from mercury_engine_data_structures.formats import BaseResource" with "from mercury_engine_data_structures.formats.base_resource import BaseResource"
- replace "from mercury_engine_data_structures.formats import standard_format" with "from mercury_engine_data_structures.formats.standard_format import <create | game_model> and updated code to remove "standard_format." prefix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 74.53% 74.62% +0.09%
==========================================
Files 65 65
Lines 3255 3267 +12
==========================================
+ Hits 2426 2438 +12
Misses 829 829 ☔ View full report in Codecov by Sentry. |
henriquegemignani
requested changes
Jul 15, 2024
| from mercury_engine_data_structures.game_check import Game | ||
|
|
||
| BMBLS = standard_format.create('base::animation::CBlendSpaceResource', 0x02020001) | ||
| BMBLS = create('base::animation::CBlendSpaceResource', 0x02020001) |
There was a problem hiding this comment.
I prefer to import the module instead of a function from the module. And this change makes no difference for loops.
There was a problem hiding this comment.
okay, I reverted that change. surprised that worked since I thought the circular import issue was from calling from mercury_engine_data_structures.formats import XYZ
- replaced "from m_e_d_s.formats import BaseResource" with "from m_e_d_s.formats.base_resource import BaseResource"
steven11sjf
force-pushed
the
fix/formats-circular-imports
branch
from
52cc9bb
to
8b20364
Compare
for more information, see https://pre-commit.ci
henriquegemignani
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.