Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to tell self-host CI to use merge queue #110

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented Dec 18, 2023

grafik

Could be that because the runner only runs stuff on branches main, that it never gets to run the temporary merge queue branches.

@ThanatosGit
Copy link
Contributor

What is this about? The merge queue was already in use before and therefore I don't see the relation on a quick glance. (see the recent closed+merged prs).
Did something changed in the last days about that?

@Miepee
Copy link
Contributor Author

Miepee commented Dec 18, 2023

oh you're right. didn't notice that, thought the merge queue was new.
There's something weird with bots then. all MRs done by humans were added to the merge queue fine. All MRs done by bots (#102, #100, #78, #72) all timed out in the merge queue due to CI not running, and had to be fixed by a human.

@ThanatosGit
Copy link
Contributor

In ODR it works but it's just using a wildcard: https://github.com/randovania/open-dread-rando/blob/main/.github/workflows/python.yml

Copy link
Contributor

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it. Otherwise we simply change to the wildcard * like in the other repos?!

@ThanatosGit ThanatosGit added this pull request to the merge queue Dec 18, 2023
@Miepee
Copy link
Contributor Author

Miepee commented Dec 18, 2023

sounds good.
and if that still doesn't work, revert ig.

Merged via the queue into main with commit 6027d8e Dec 18, 2023
8 checks passed
@ThanatosGit ThanatosGit deleted the Miepee-patch-2 branch December 18, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants