Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pkg alignment for SR #103

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

dyceron
Copy link
Contributor

@dyceron dyceron commented Nov 24, 2023

Samus Returns requires a different pkg alignment than Dread. This allows the files to be built properly and allow the rando to function on console (and fix Citra issues).

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0e58da4) 73.94% compared to head (ada594b) 73.94%.

Files Patch % Lines
src/mercury_engine_data_structures/formats/pkg.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   73.94%   73.94%   -0.01%     
==========================================
  Files          61       61              
  Lines        3113     3116       +3     
==========================================
+ Hits         2302     2304       +2     
- Misses        811      812       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: It is not the correct alignment to recreate the original pkgs. It is at least a not breaking one on console and the best we get for now.
Maybe some day we will find out.

@ThanatosGit ThanatosGit added this pull request to the merge queue Nov 24, 2023
Merged via the queue into randovania:main with commit f677121 Nov 24, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants