Update azure.md #1494
Open
Update azure.md #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note about uninitialized taint Corrected yaml indentation as existing indentation was wrong and breaking copy/paste of configs
celidon
requested review from
btat,
LucasSaintarbor,
martyav and
sunilarjun
as code owners
btat
requested changes
Oct 10, 2024
| @@ -100,7 +100,7 @@ This section is valid only for creating clusters with the in-tree cloud provider | |||
| <details id="v2.6.0-cloud-provider-config-file"> | |||
| <summary>Example Cloud Provider Config</summary> | |||
|
|
|||
| ```yaml | |||
| ```yaml | |||
There was a problem hiding this comment.
What's the expected rendered output here? This block doesn't seem to have the same missing indentation as the other blocks.
The build is also failing without the existing indentation.
Comment on lines
+215
to
+217
| :::note | ||
| When setting **Cloud Provider** to **External**, all nodes will automatically be tainted with node.cloudprovider.kubernetes.io/uninitialized=true until the Cloud Provder is installed. It is recommended to deploy the CPI as an add-on job as described below. | ||
| ::: |
There was a problem hiding this comment.
Suggested change
| :::note | |
| When setting **Cloud Provider** to **External**, all nodes will automatically be tainted with node.cloudprovider.kubernetes.io/uninitialized=true until the Cloud Provder is installed. It is recommended to deploy the CPI as an add-on job as described below. | |
| ::: | |
| :::note | |
| When setting **Cloud Provider** to **External**, all nodes are automatically tainted with `node.cloudprovider.kubernetes.io/uninitialized=true` until the Cloud Provider is installed. It is recommended to deploy the CPI as an add-on job as described below. | |
| ::: |
Suggestion updates the text to present tense and adds indentation so the note aligns with the text of step 1.
|
@btat That'd be great if you can port that across all versions of the docs. I totally spaced that I need to make any edits to each version of that page and just went in to edit the one page my customer was having issues with due to invalid yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about uninitialized taint
Corrected yaml indentation as existing indentation was wrong and breaking copy/paste of configs
Fixes #[issue_number]
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Comments