Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] rancher-logging 104.0.0 support resources on daemonsets #4295

Open
wants to merge 1 commit into
base: dev-v2.9
Choose a base branch
from

Conversation

ricoapon
Copy link

@ricoapon ricoapon commented Jul 25, 2024

Issue

I did not report one (just created this PR) and couldn't find an existing issue.
EDIT: created rancher/rancher#46499 for this.

Problem

Rancher-logging instals DaemonSets, which did not have any way to limit resources. This gave problems on our Kubernetes cluster where the pods could use 50% of the node memory.

Solution

Make it possible to configure the resources on DaemonSets. Default should stay the same (no limits configured).

Engineering Testing

Manual Testing

I installed the Helm chart manually on our own cluster to check that the rke2 code works.

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant