Improve readability of WatchForService function

Signed-off-by: Nino Kodabande <[email protected]>

cmd/rancher-desktop-guestagent/main.go

@@ -181,7 +181,7 @@ func main() {
 			k8sServiceListenerIP := net.ParseIP(*k8sServiceListenerAddr)
 
 			if k8sServiceListenerIP == nil || !(k8sServiceListenerIP.Equal(net.IPv4zero) ||
-				k8sServiceListenerIP.Equal(net.IPv4(127, 0, 0, 1))) { //nolint:gomnd,mnd // IPv4 addr localhost
+				k8sServiceListenerIP.Equal(net.IPv4(127, 0, 0, 1))) {
 				log.Fatalf("empty or none valid input for Kubernetes service listener IP address %s. "+
 					"Valid options are 0.0.0.0 and 127.0.0.1.", *k8sServiceListenerAddr)
 			}

pkg/kube/watcher.go

@@ -123,20 +123,17 @@ func WatchForServices(
 			eventCh, errorCh, err = watchServices(watchContext, clientset)
 			if err != nil {
 				switch {
+				default:
+					return err
 				case isTimeout(err):
-					fallthrough
 				case errors.Is(err, unix.ENETUNREACH):
-					fallthrough
 				case errors.Is(err, unix.ECONNREFUSED):
-					fallthrough
 				case isAPINotReady(err):
-					// sleep and continue for all the expected case
-					time.Sleep(time.Second)
-
-					continue
-				default:
-					return err
 				}
+				// sleep and continue for all the expected case
+				time.Sleep(time.Second)
+
+				continue
 			}
 
 			log.Debugf("watching kubernetes services")
@@ -267,6 +264,10 @@ func isTimeout(err error) bool {
 	return false
 }
 
+// This is a k3s error that is received over
+// the HTTP, Also, it is worth noting that this
+// error is wrapped. This is why we are not testing
+// against the real error object using errors.Is().
 func isAPINotReady(err error) bool {
 	return strings.Contains(err.Error(), "apiserver not ready")
 }