-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Pandas FutureWarnings #1766
Resolve Pandas FutureWarnings #1766
Conversation
Changed fillna, iloc, and added test changes
I also had to manually pip install packages not in |
Requests caching and rate-limiting are optional for users, and while required for tests I figure developers are smart enough to install. Btw the requirement is to avoid tests spamming Yahoo. So not strictly required, but highly recommended. |
Maybe we should add this requirements with pip[optional]? docs stockoverflow |
Fine with me. I propose naming |
Should we include scipy as an optional req too? I noticed it was also purposely excluded in base.py#L872. If we want it separate, both pandas_datareader and scipy could be under extras_require={
'nospam': ['requests_cache>=1.1.1', 'requests_ratelimiter>=0.4.2'],
'optional': ['scipy>=1.10.1', 'pandas_datareader>=0.10.0'],
}, |
I don't mind, but if yes then I propose naming
|
Wait for this optional dependencies discussion to resolve.
Sounds good, I can add the discussed extra dependencies to Also with respect to documentation, does this need to be added somewhere like the readme? |
Create a new PR, reference this for background discussion. Should have done this earlier tbh. Update README too, maybe move install section to top, and replace requirements with link to file. |
Fixes #1739 :
reconstruct_intervals_batch
function.test_reconstruct_intervals_batch
, also validated against current output.