Dbal4 compat #253
Closed
Dbal4 compat #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatiliby with DBAL 3 is retained, so that it is possible to upgrade this library without also having to upgrade DBAL. Closes ramsey#246
kochen
reviewed
Mar 13, 2024
| @@ -5,3 +5,9 @@ parameters: | |||
| paths: | |||
| - ./src | |||
| - ./tests | |||
| ignoreErrors: | |||
| # That class no longer holds methods in DBAL 4, but needs to be called with DBAL 3 | |||
| - message: '#Call to an undefined static method Doctrine\\DBAL\\Types\\ConversionException::.*#' | |||
There was a problem hiding this comment.
@greg0ire this will throw an error when the method does exists (i,e in DBAL v4)
There was a problem hiding this comment.
You're right. Either set reportUnmatchedErrors to false, or use different configs for different jobs, or run static analysis with only one version of DBAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #247