Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added footer #7

Closed
wants to merge 1 commit into from
Closed

Added footer #7

wants to merge 1 commit into from

Conversation

aryamanpuri
Copy link

@aryamanpuri aryamanpuri commented Nov 30, 2019

@rajat2502
Copy link
Owner

Hey!!! thanks for contributing, there is an issue the footer should be fixed to the bottom of the content and not to the viewport. In this pr, the footer is fixed to the bottom of the page. If you can fix this somehow then go ahead!!!

@aryamanpuri
Copy link
Author

aryamanpuri commented Nov 30, 2019

@rajat2502 But in #3 It is about "Fix the footer to the bottom of the page even when the content doesn't completely fits the full height of the page."
So what should I do?
Footer in the bottom or at the end of content ?

@rajat2502
Copy link
Owner

@aryamanpuri The footer should be at the bottom of the page(not viewport). If the content do not properly fit the height of even a viewport then it should be at the bottom of the page and when the content is more than 100vh then it should come after the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants