Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom slippage #1708

Merged
merged 12 commits into from
Sep 25, 2024
Merged

fix: custom slippage #1708

merged 12 commits into from
Sep 25, 2024

Conversation

estebanmino
Copy link
Member

@estebanmino estebanmino commented Sep 23, 2024

Fixes BX-4828
Figma link (if any):

What changed (plus any additional context for devs)

custom slippage wasn't working on prod so e2e was sending swaps with a very low slippage value

also edited e2e flow to correctly type values in slippage and swaps input to make e2e work

Screen recordings / screenshots

What to test

@estebanmino estebanmino changed the title wip e2e fix: custom slippage Sep 24, 2024
@estebanmino estebanmino marked this pull request as ready for review September 24, 2024 21:37
Copy link

socket-security bot commented Sep 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rollup/[email protected] None 0 1.47 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.05 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.18 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.32 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.21 MB lukastaegert
npm/@rollup/[email protected] None 0 2.23 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.12 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.76 MB lukastaegert
npm/@rollup/[email protected] None 0 2.25 MB lukastaegert
npm/@rollup/[email protected] None 0 3.8 MB lukastaegert
npm/@rollup/[email protected] None 0 2.49 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.48 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.74 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.53 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 3.28 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/[email protected] None 0 2.27 MB eventualbuddha, lukastaegert, rich_harris, ...2 more
npm/[email protected] None 0 667 kB colinmcd94

🚮 Removed packages: npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Member

@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested e2e and a swap with custom slippage

@estebanmino estebanmino merged commit ae5df21 into master Sep 25, 2024
14 checks passed
@estebanmino estebanmino deleted the fix-e2e branch September 25, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants