Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help swaps flakiness #1683

Closed
wants to merge 16 commits into from
Closed

Help swaps flakiness #1683

wants to merge 16 commits into from

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Aug 27, 2024

Looks like a lot of changes but it's not really:

  • wrapped the swaps flows in a describe wrapper, which makes the 'lines changes' really long, sorry
  • added a few helpers to try and check exact transaction hashes by address to find the most recent sent txn by the test wallet, and see if the txn was successful. If not, it waits and checks again.
  • this is better than some non-specific delays imo, and i think will help make the tests more consistent
  • the two swaps flows were cut back several times, and so we were basically duplicating the entire test file to just swap USDC in the 2nd swap test. I instead just moved this to the end of the first test. This should make test times shorter, and hopefully help with flakiness by removing room for error

@BrodyHughes BrodyHughes requested review from greg-schrammel and removed request for greg-schrammel, derHowie and estebanmino September 3, 2024 17:15
@jinchung jinchung added the e2e label Sep 5, 2024
@jinchung jinchung removed the request for review from DanielSinclair September 5, 2024 18:16
@BrodyHughes BrodyHughes changed the title Brody/test swaps flow Help swaps flakiness Sep 6, 2024
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be solved first

@BrodyHughes BrodyHughes marked this pull request as draft September 9, 2024 18:56
@BrodyHughes
Copy link
Member Author

will look at this again at a later date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants