Merge branch 'master' into @chris/e2e-fixes

rainbow-me · Sep 18, 2024 · fc230dc · fc230dc
2 parents 4a646f7 + 394cef3
commit fc230dc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "browser-extension",
   "license": "GPL-3.0-only",
-  "version": "1.5.39",
+  "version": "1.5.40",
   "scripts": {
     "//enable dev mode": "",
     "devmode:on": "sed -i'' -e 's/IS_DEV.*/IS_DEV=true/g' .env",

diff --git a/src/entries/popup/hooks/swap/useSwapQuote.ts b/src/entries/popup/hooks/swap/useSwapQuote.ts
@@ -57,12 +57,12 @@ export const useSwapQuote = ({
   );
 
   const quotesParams: QuoteParams | undefined = useMemo(() => {
-    const paramsReady =
-      assetToSell &&
-      assetToBuy &&
-      (independentField === 'buyField'
+    const independentValue =
+      independentField === 'buyField'
         ? Number(assetToBuyValue)
-        : Number(assetToSellValue));
+        : Number(assetToSellValue);
+    const paramsReady =
+      assetToSell && assetToBuy && typeof independentValue === 'number';
     if (!paramsReady) return undefined;
 
     return {

diff --git a/static/manifest.json b/static/manifest.json
@@ -68,7 +68,7 @@
     "notifications"
   ],
   "short_name": "Rainbow",
-  "version": "1.5.39",
+  "version": "1.5.40",
   "web_accessible_resources": [
     {
       "matches": [