Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence encoding warnings in specs #857

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

p8
Copy link
Member

@p8 p8 commented Aug 9, 2023

Setting Encoding.default_external prints a warning when running specs:

 warning: setting Encoding.default_external

Wrapping this with a silence_warnings block, silences the warnings.

Setting `Encoding.default_external` prints a warning when running specs:

   warning: setting Encoding.default_external

Wrapping this with a `silence_warnings` block, silences the warnings.
@p8 p8 force-pushed the silence-encoding-warning branch from 3af5005 to 2ef9fd7 Compare August 9, 2023 19:26
@rafaelfranca rafaelfranca merged commit d9efc81 into rails:main Aug 21, 2023
7 checks passed
@p8 p8 deleted the silence-encoding-warning branch August 21, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants