Add comment on expiration query

rails · Sep 10, 2024 · ec6b58c · ec6b58c
1 parent f1d3f57
commit ec6b58c
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/app/models/solid_cache/entry/expiration.rb b/app/models/solid_cache/entry/expiration.rb
@@ -40,6 +40,8 @@ def expiry_candidate_ids(count, max_age:, max_entries:, max_size:)
                 candidates.pluck(:id)
               else
                 min_created_at = max_age.seconds.ago
+                # We don't have an index on created_at, but we can select
+                # the records by id and they'll be in created_at order.
                 candidates.pluck(:id, :created_at)
                           .filter_map { |id, created_at| id if created_at < min_created_at }
               end