Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate settings already configured by default #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,27 +48,11 @@ Layout/EmptyLinesAroundModuleBody:
Layout/EndAlignment:
Enabled: true
EnforcedStyleAlignWith: variable
AutoCorrect: true

# Method definitions after `private` or `protected` isolated calls need one
# extra level of indentation.
#
# We break this rule in context, though, e.g. for private-only concerns,
# so we leave it disabled.
Layout/IndentationConsistency:
Enabled: false
EnforcedStyle: indented_internal_methods

# Detect hard tabs, no hard tabs.
Layout/IndentationStyle:
Enabled: true

# Two spaces, no tabs (for indentation).
#
# Doesn't behave properly with private-only concerns, so it's disabled.
Layout/IndentationWidth:
Enabled: false

Layout/LeadingCommentSpace:
Enabled: true

Expand Down Expand Up @@ -103,7 +87,6 @@ Layout/SpaceInLambdaLiteral:
Layout/SpaceInsideArrayLiteralBrackets:
Enabled: true
EnforcedStyle: space
EnforcedStyleForEmptyBrackets: no_space

# Use `%w[ a b ]` not `%w[ a b ]`.
Layout/SpaceInsideArrayPercentLiteral:
Expand All @@ -119,19 +102,11 @@ Layout/SpaceInsideBlockBraces:
# Use `{}` not `{ }`.
Layout/SpaceInsideHashLiteralBraces:
Enabled: true
EnforcedStyle: space
EnforcedStyleForEmptyBraces: no_space

# Use `foo(bar)` not `foo( bar )`
Layout/SpaceInsideParens:
Enabled: true

# Requiring a space is not yet supported as of 0.59.2
# Use `%w[ foo ]` not `%w[foo]`
Layout/SpaceInsidePercentLiteralDelimiters:
Enabled: false
#EnforcedStyle: space

# Use `hash[:key]` not `hash[ :key ]`
Layout/SpaceInsideReferenceBrackets:
Enabled: true
Expand Down Expand Up @@ -164,20 +139,6 @@ Performance/FlatMap:
Performance/UnfreezeString:
Enabled: true

# Prefer assert_not over assert !
Rails/AssertNot:
Include:
- "test/**/*"

# Prefer assert_not_x over refute_x
Rails/RefuteMethods:
Include:
- "test/**/*"

# We generally prefer &&/|| but like low-precedence and/or in context
Style/AndOr:
Enabled: false

# Prefer Foo.method over Foo::method
Style/ColonMethodCall:
Enabled: true
Expand All @@ -199,17 +160,6 @@ Style/ParenthesesAroundCondition:

Style/PercentLiteralDelimiters:
Enabled: true
PreferredDelimiters:
default: "()"
"%i": "[]"
"%I": "[]"
"%r": "{}"
"%w": "[]"
"%W": "[]"

# Use quotes for string literals when they are enough.
Style/RedundantPercentQ:
Enabled: false

Style/RedundantReturn:
Enabled: true
Expand Down