fix test-case vs devise vs rails 4.2

[grosser]

should solve #23 and #32

@rafaelfranca @walterdavis @guigs

[matthewd]

Checking the environment really is very dirty... can we:

if ActionView.const_defined?(:TestCase) && !ActionView.autoload?(:TestCase)

? Or isn't TestCase loaded yet, even in test?

[grosser]

it is in test, but doing const_defined? is always true / there is no way to
check if it is actually loaded

>> defined?(ActionView::TestCase)
=> "constant"
>> ActionView.const_defined?(:TestCase)
=> true
>> ActionView::TestCase
actual load -> booom

On Sat, Dec 13, 2014 at 1:40 AM, Matthew Draper [email protected]
wrote:

Checking the environment really is very dirty... can we:

if ActionView.const_defined?(:TestCase) && !ActionView.autoload?(:TestCase)

? Or isn't TestCase loaded yet, even in test?

—
Reply to this email directly or view it on GitHub
#33 (comment).

[grosser]

@rafaelfranca @walterdavis @guigs

[guigs]

I've applied this to 4.2 branch in my fork of prototype-rails and it is working with my app.

[rafaelfranca]

Can we check defined?(Rails.env)?

[rafaelfranca]

The problem with this is if users is testing in a cucumber environment it will not load these helpers.

[grosser]

the idea was to only load it in test mode, so defined?(Rails.env) will also be true for development and others

how about ['cucumber', 'test'].include?(Rails.env) ?
there is always the fallback option of doing the include manually, so even if we miss some edge case it's not that bad

[rafaelfranca]

I mean if defined?(Rails.env) && Rails.env.test?.

I really thing we should not check any environment but I can't think in a better option besides a configuration.

[grosser]

Ah yes, that should work and is a bit safer, changed!

On Wed, Jan 21, 2015 at 7:48 AM, Rafael Mendonça França <
[email protected]> wrote:

In lib/prototype-rails/on_load_action_view.rb
#33 (comment):

@@ -14,9 +14,11 @@
include ActionView::Helpers::ScriptaculousHelper
end

-ActionView::TestCase.class_eval do

• include ActionView::Helpers::PrototypeHelper
• include ActionView::Helpers::ScriptaculousHelper
  +if defined?(Rails) && Rails.env.test?

I mean if defined?(Rails.env) && Rails.env.test?.

I really thing we should not check any environment but I can't think in a
better option besides a configuration.

—
Reply to this email directly or view it on GitHub
https://github.com/rails/prototype-rails/pull/33/files#r23308286.

[grosser]

@rafaelfranca good to go now ?

[rafaelfranca]

I still don't think checking environment is a good option 😢, but I guess there is no other way of doing it.

[grosser]

Let's wait for the next PR complaining on this ;)

On Thu, Jan 22, 2015 at 10:41 AM, Rafael Mendonça França <
[email protected]> wrote:

Merged #33 #33.

—
Reply to this email directly or view it on GitHub
#33 (comment).