do not load test-case in development

[grosser]

@fxn @jeremy

[grosser]

can you also pick this to the rails 3 branch ?

[grosser]

bump

[rafaelfranca]

This entire code should be inside the Railtie

[grosser]

better ?

[rafaelfranca]

Sorry. I was talking about only the Rails.env check and the conditional inclusion of modules at TestCase. The rest of the code is fine to be in that file

[grosser]

Ok, more like this ?

On Thu, Jan 2, 2014 at 5:33 PM, Rafael Mendonça França <
[email protected]> wrote:

In lib/prototype-rails.rb:

•    require 'action_view/helpers/scriptaculous_helper'
  

•    require 'action_view/template/handlers/rjs'
  

•    require 'prototype-rails/javascript_helper'
  

•    require 'prototype-rails/rendering'
  

•    ActionView::Base.class_eval do
  

•      cattr_accessor :debug_rjs
  

•      self.debug_rjs = false
  

•    end
  

•    ActionView::Base.class_eval do
  

•      include ActionView::Helpers::PrototypeHelper
  

•      include ActionView::Helpers::ScriptaculousHelper
  

•    end
  

•    if Rails.env.test? # do not trigger test-case autoload in development/production
  

Sorry. I was talking about only the Rails.env check and the conditional
inclusion of modules at TestCase. The rest of the code is fine to be in
that file

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/28/files#r8628297
.

[rafaelfranca]

👍

[grosser]

Can you also merge and release this?

[rafaelfranca]

Sure! It is in my TODO list. Will be the first thing I'll do tomorrow

[grosser]

Hmm tomorrow is gone :)

[rafaelfranca]

yes, yes. Sorry I have a lot of work to do.

But you can always install a gem pointing to your fork using bundler if you have hurry 😉

[grosser]

pff you only maintain like 2 or 300 projects, how hard can that be ;)
I already did the git dependency, but would love to make it a real gem :>

On Mon, Jan 6, 2014 at 9:23 AM, Rafael Mendonça França <
[email protected]> wrote:

yes, yes. Sorry I have a lot of work to do.

But you can always install a gem pointing to your fork using bundler if
you have hurry [image: 😉]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/28#issuecomment-31667105
.

[rafaelfranca]

Now I can work on this. Thanks ❤️

[grosser]

bump :)
(please also release for the rails 3 branch/tag, I can make a PR if that helps, just picking the commit on the latest rails 3 tag)

[rafaelfranca]

Really sorry but before releasing the gem I want to do some work. Like I said we don't need to hurry to release the gem since you can always use bundler.

[grosser]

Sure, take your time :)

On Mon, Jan 13, 2014 at 9:19 AM, Rafael Mendonça França <
[email protected]> wrote:

Really sorry but before releasing the gem I want to do some work. Like I
said we don't need to hurry to release the gem since you can always use
bundler.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/28#issuecomment-32190147
.

[rafaelfranca]

I want to review all the open PR and issues and see if I can merge/fix something else before releasing, so the release will help more people

[grosser]

no more PR's left except some 6month + olds, ready to release ?

[guigs]

This would solve #32 on Rails 4.2.