Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove full-stack Rails as a dependency #121

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nimmolo
Copy link

@nimmolo nimmolo commented May 16, 2024

mission_control-jobs does not appear to depend on the whole Rails stack.

I would like to try the gem in production, but our app does not need to load ActiveStorage, ActionText or ActionMailbox. I think it's pretty common for people to just use some Rails gems.

Other gem examples:

@nimmolo
Copy link
Author

nimmolo commented Jul 25, 2024

@dorianmariecom pourquoi le downvote?

@dorianmariecom
Copy link
Contributor

@nimmolo I think rails-related gems should just depend on rails, that's a lot simpler to maintain and accounts for 99% of use cases

@rosa
Copy link
Member

rosa commented Aug 21, 2024

@nimmolo, could you run bundle install and commit the updated Gemfile.lock?

@nimmolo
Copy link
Author

nimmolo commented Aug 21, 2024

@rosa Thanks!
I should have done that before...
Done.

@nimmolo
Copy link
Author

nimmolo commented Aug 21, 2024

@rosa I don't know how to fix the CI failures, but i'm happy to do more if you can suggest what to do. I figure it must need to be set up to work with/test many different Ruby versions, but i've never done this before.

I can install all the Ruby versions, but that seems like it will only affect my local.

@rosa
Copy link
Member

rosa commented Aug 21, 2024

Thanks a lot, @nimmolo! No worries, I'll check those. It seems they're happening independently of the Ruby version:

cannot load such file -- action_cable/engine (LoadError)
	from /opt/hostedtoolcache/Ruby/3.3.4/x64/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from bin/rails:21:in `<main>'

Ah, yes, because bin/rails needs to be updated as well, to look more similar to this. Right now it's loading everything:

require "rails/all"

@rosa
Copy link
Member

rosa commented Aug 21, 2024

Sorry I'm dumb! 😆 It's late over here 😆 The line number didn't match the error, and then I realised you did that already in this PR! But it seems you left action_cable here, so I think that one should go.

@nimmolo
Copy link
Author

nimmolo commented Aug 21, 2024

Got it... committed that change.

@nimmolo
Copy link
Author

nimmolo commented Oct 2, 2024

@rosa - congrats on the 1.0 release!

I am psyched to start using mission control jobs... I think this PR is ready to merge, I've made the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants