-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove full-stack Rails as a dependency #121
base: main
Are you sure you want to change the base?
Conversation
@dorianmariecom pourquoi le downvote? |
@nimmolo I think rails-related gems should just depend on rails, that's a lot simpler to maintain and accounts for 99% of use cases |
@nimmolo, could you run |
@rosa Thanks! |
@rosa I don't know how to fix the CI failures, but i'm happy to do more if you can suggest what to do. I figure it must need to be set up to work with/test many different Ruby versions, but i've never done this before. I can install all the Ruby versions, but that seems like it will only affect my local. |
Thanks a lot, @nimmolo! No worries, I'll check those. It seems they're happening independently of the Ruby version:
Ah, yes, because mission_control-jobs/bin/rails Line 13 in 7f71ec8
|
Sorry I'm dumb! 😆 It's late over here 😆 The line number didn't match the error, and then I realised you did that already in this PR! But it seems you left |
Got it... committed that change. |
@rosa - congrats on the 1.0 release! I am psyched to start using mission control jobs... I think this PR is ready to merge, I've made the requested changes. |
mission_control-jobs
does not appear to depend on the whole Rails stack.I would like to try the gem in production, but our app does not need to load ActiveStorage, ActionText or ActionMailbox. I think it's pretty common for people to just use some Rails gems.
Other gem examples: