Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test:arel to test separately from adapters #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test:arel to test separately from adapters #37

wants to merge 1 commit into from

Commits on Jun 27, 2023

  1. Add test:arel to test separately from adapters 

    Previously, all of the Arel tests would be run with every database
adapter. This is not necessarily a problem, but these tests end up
running redundantly for each adapter/database combination even though
they do not interact with adapters at all.

This commit follows up a [commit][1] in Rails that added a new test:arel
task for Active Record. This additional step creates a place for Arel to
be tested a single time, so that a followup PR to Rails can filter out
Arel tests when testing adapters.

Since the task is only present on the main branch, it cannot run for all
Rails versions and must be a special case.

[1] rails/rails@f362f07
    @skipkayhil
    skipkayhil committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7d95a97 View commit details
    Browse the repository at this point in the history