Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Release - 2.6.1 #59

Merged
merged 13 commits into from
Jun 2, 2020
Merged

Prepare Release - 2.6.1 #59

merged 13 commits into from
Jun 2, 2020

Conversation

rpbaltazar
Copy link
Contributor

@rpbaltazar rpbaltazar commented Jun 1, 2020 •
edited
Loading

fsateler and others added 13 commits May 18, 2020 09:30
@fsateler @rpbaltazar
Avoid getting a connection to the database before it's necessary
26fc746 
We init the first time we request a connection. On code reloads, we
"forget" about our init state and we call it again.

After init, ensure the search path is set properly
@rpbaltazar
[Fix] Custom Console should require apartment console
73dc066
@rpbaltazar
[#52] enhance after db create
1a27a89
@rpbaltazar
[#52] fixing gem requirements based in test output
2c51aab
@rpbaltazar
[52] fixed failing specs
52874a8
@rpbaltazar
[#52] Addressed rubocop issues
b625e03
@rpbaltazar
[#52] fixed failing specs
833a145
@rpbaltazar
[#52] added logging to debug on ci
7c2fe95
@rpbaltazar
[#52] ci uses lower case
ac98968
@rpbaltazar
[#52] fix rubocop
e94a442
@fsateler @rpbaltazar
fix: reset sequence_name after tenant switch
f8eefc4 
The sequence_name contains the schema name, so after switching we point to the wrong one.

Gems such as ActiveRecord-Import use it
@fsateler @rpbaltazar
fix init after reload on development
3cfaeb4 
On 26fc746, init is not forced to be executed on `to_prepare`. This helps us avoid a connection at startup.
However, things break down after a reload because things like `ExcludedModel.count` don't go through
the `connection` method that we overrode, at least until after we
queried the table name.

Let's make sure that we initialize before using arel too.
@rpbaltazar
Excluding default schema from tasks
443bebf
@rpbaltazar rpbaltazar marked this pull request as ready for review June 1, 2020 11:37
@rpbaltazar rpbaltazar changed the title Prepare Release Prepare Release - 2.6.1 Jun 1, 2020
@rpbaltazar rpbaltazar merged commit 1dd198d into master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpbaltazar @fsateler