Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AdditionalContent Parameter to Scheduler #1717

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

bikotoru
Copy link
Contributor

@bikotoru bikotoru commented Oct 1, 2024

This PR introduces a new parameter, AdditionalContent, to the scheduler component. It allows developers to add custom content next to the year, month, and day buttons, providing more flexibility for adding additional controls or information to the scheduler's header area.

Changes:

  • Added AdditionalContent parameter of type RenderFragment.
  • Updated documentation comments to describe the parameter's functionality.

This feature improves the customizability of the scheduler and addresses the need for more adaptable UI elements.

Please review the implementation and let me know if there are any changes needed.

…xt to year, month, and day buttons in RadzenScheduler
@akorchev
Copy link
Collaborator

akorchev commented Oct 1, 2024

Hi @bikotoru,

Thank you for the PR. Can we think of a better name than AdditionalContent? It isn't clear where this additional content will go.

@bikotoru
Copy link
Contributor Author

bikotoru commented Oct 1, 2024

@akorchev
PersonalizedView?
CustomView?
AdditionalView?

I'm kind of bad with names haha

@akorchev
Copy link
Collaborator

akorchev commented Oct 1, 2024

What is the purpose of this to begin with? What do you want to add there?

@bikotoru
Copy link
Contributor Author

bikotoru commented Oct 1, 2024

@akorchev
For example a Refresh Button or ComboBox with Filters

@akorchev
Copy link
Collaborator

akorchev commented Oct 1, 2024

What bothers me is that it renders together with the default navigation (and the name). Somebody would ask for it to render before and not after. I can propose a different implementation - NavigationTemplate which replaces the whole navigation section - easier to name and provides full control. The existing navigation can be emulated with existing components too. What do you think?

@bikotoru
Copy link
Contributor Author

bikotoru commented Oct 1, 2024

@akorchev
perfect I have applied the change

@akorchev akorchev merged commit 1d869e8 into radzenhq:master Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants