Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update android restore copy #508

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Update android restore copy #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec08c8
updated android restore copy
giannis-rdx Sep 17, 2024
2221488
missing iOS Strings
matiasbzurovski Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Content/Recover Profile Backup/recoverProfileBackup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"recoverProfileBackup_header_title": "Restore Wallet From Backup",
"recoverProfileBackup_header_subtitle": "Select a backup to restore your Radix Wallet. You will be asked to enter your seed phrase(s) to recover control of your Accounts and Personas.",
"androidRecoverProfileBackup_choose_title": "Choose a backup",
"androidRecoverProfileBackup_choose_title": "Choose a backup from Google Drive",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that is necessary now, but seems this particular file is defining Strings using the wrong prefix.
Instead of:

"androidRecoverProfileBackup_choose_title"

we should have any like the following:

"recoverProfileBackup_android_chooseTitle"
"recoverProfileBackup_choose_android"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have defined many strings this way.
Let's better take this in a separate task/ticket.

Screenshot 2024-09-17 at 16 04 12

"iOSRecoverProfileBackup_choose_title": "Choose a backup on iCloud",
"iOSRecoverProfileBackup_noBackupsAvailable": "No wallet backups available on current iCloud account",
"iOSRecoverProfileBackup_notLoggedInToICloud": "Not logged in to iCloud",
Expand All @@ -16,5 +16,12 @@
"recoverProfileBackup_incompatibleWalletDataLabel": "Incompatible Wallet data",
"recoverProfileBackup_passwordWrong": "The password is wrong",
"recoverProfileBackup_backupNotAvailable": "Backup not available?",
"recoverProfileBackup_otherRestoreOptionsButton": "Other Restore Options"
"recoverProfileBackup_otherRestoreOptionsButton": "Other Restore Options",
"recoverProfileBackup_choose_iOS": "Choose a backup on iCloud",
"recoverProfileBackup_noBackupsAvailable_iOS": "No wallet backups available on current iCloud account",
"recoverProfileBackup_notLoggedIn_iOS": "Not logged in to iCloud",
"recoverProfileBackup_networkUnavailable": "Network unavailable",
"recoverProfileBackup_couldNotLoadBackups": "Could not load backups",
"recoverProfileBackup_updateSystemSetings": "Update in System Settings",
"recoverProfileBackup_thisDevice": "This Device"
}