rad-ci: Initial commit #35

xphoniex · 2022-02-08T12:46:02Z

No description provided.

src/bin/rad-ci.rs

help/src/lib.rs

cloudhead · 2022-02-09T09:15:48Z

src/bin/rad-ci.rs

+            "Couldn't retrieve ssh-agent key #{}",
+            options.ssh_index
+        ))?;
+        agent.userauth(&options.ssh_user, identity)?;


Passing a key index is kind of weird, can we not pass a key path?

theres ssh which supports key path, but instead of using an index, we could do what other programs do, simply iterate over all keys and return error if all fail. Thoughts?

(I think avoiding key path in favor of ssh-agent is a better option, now that I used it)

I went ahead and removed index, instead now we iterate over all keys. (Just like ssh itself does)

cloudhead

This is cool, left some comments and will try it out when I have time.

src/bin/rad-ci.rs

cloudhead · 2022-02-09T09:20:52Z

src/bin/rad-ci.rs

+
+        let mut remote_file = sess
+            .scp_send(
+                std::path::Path::new("/etc/concourse-docker-compose.yml"),


Why not in the user's home directory? It's unlikely they can write to /etc?

actually, I think we should use /app/radicle/etc, what do you think?

Also problematic, it won't work unless they have a docker install with our docker images.

src/bin/rad-ci.rs

ci/src/lib.rs

xphoniex · 2022-02-11T13:45:37Z

receive-hook needs an .env file to source user/pass and url of concourse server so I added extract-env which uses grep and cut to extract those values from yaml file. Not ideal, but works for now.

cloudhead · 2022-02-12T16:47:03Z

src/bin/rad-ci.rs

+use rad_ci::{run, Options, HELP};
+
+fn main() {
+    rad_terminal::args::run_command::<Options, _>(HELP, "ci", run);


The string here is prepended to failure messages like this: {string} failed: {error}.

So let's set it to just "Command" if this tool can do multiple things, then it'll show Command failed: {error}.

Are you sure about this? won't be too informative, also as of now, it's only doing install/uninstalls.

ci/receive-hook

cloudhead · 2022-02-12T16:55:41Z

ci/src/lib.rs

+            receive_hook_content.as_bytes(),
+            "/app/radicle/hooks/receieve-hook",
+            0o755,
+        );


This is not going to work, as you don't know how --root was configured on the server. I think it's best to either have a --remote-root flag to specify it, or to let users install this file manually.

xphoniex · 2022-02-14T13:25:11Z

added --root argument which should fix issues with paths, etc.

Signed-off-by: xphoniex <[email protected]>

xphoniex requested a review from cloudhead as a code owner February 8, 2022 12:46

xphoniex force-pushed the dave/add-ci branch 4 times, most recently from 0b24d9c to abd8fbe Compare February 8, 2022 15:48