Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle JUNK in your CHUNK #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geoffreyfloyd
Copy link

The WAV files created by Adobe Audition include a 'JUNK' chunk that comes before the 'fmt' chunk, so code was added to recognize the JUNK chunk, move past it, and properly continue with the expected fmt chunk.

@drj-io
Copy link
Member

drj-io commented Mar 28, 2016

Great, thanks Geoffrey, I use Adobe Audition often, too. I'll test this out this week.

@drj-io
Copy link
Member

drj-io commented May 25, 2016

Hi @geoffreyfloyd, everything seems to be working, but I wasn't able to generate a "junk" wav file from Adobe Audition.

Can you supply the file in question and/or advise on the following:

  • what version of Audition are you using?
  • what parameters are you using when you save the Wav file?

Hoping to replicate the issue in the current version of this module so I can finish out this pull request. Sorry this has taken so long...

Thanks for your help!

@drj-io drj-io added the ready label Dec 8, 2016
@drj-io drj-io self-assigned this Dec 8, 2016
@drj-io drj-io added the bug label Dec 8, 2016
@drj-io
Copy link
Member

drj-io commented Dec 8, 2016

@geoffreyfloyd - Did you see above? I can't test this PR without a sample file, so I'll close this if I don't hear back.

Thanks again for your help either way!

@drj-io drj-io removed the ready label Jan 11, 2017
@adrydez
Copy link

adrydez commented Apr 3, 2019

@geoffreyfloyd - Did you see above? I can't test this PR without a sample file, so I'll close this if I don't hear back.

Thanks again for your help either way!

Hi drj-io,

I try to re-open this bug. Also me found this problem in Audition. I can send you the audio files do you want. Let me know if you have a repository where I can put the audio files.

@top-kat
Copy link

top-kat commented Jun 7, 2021

Hi, I spend time looking for this fix. I tried with a junk wav file and give me an error with the main branch
but was OK with this one. Here is the file I used. I get it from my customer.

Ps, this is a zip because github don't allow uploading wav file directly.
15SEC LINGO(1).wav.zip

Looking forward for this merge request :)

Thanks for such a work 👍

@top-kat
Copy link

top-kat commented Jun 11, 2021

Hi, finally I have made a pull request that handle JUNK files correcly and other useful improvements to this great lib.
I had errors with bext wav files. This PR may be future proof because it search directly the fmt chunk, bypassing all other metadata instead of reading bytes by bytes.

#25

Bext file example: (I have a github error because the file is 35MB so uploaded to my server)
http://nicewebagence.com/bext%20wav%20example.wav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants