-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle JUNK in your CHUNK #10
base: master
Are you sure you want to change the base?
Conversation
Great, thanks Geoffrey, I use Adobe Audition often, too. I'll test this out this week. |
Hi @geoffreyfloyd, everything seems to be working, but I wasn't able to generate a "junk" wav file from Adobe Audition. Can you supply the file in question and/or advise on the following:
Hoping to replicate the issue in the current version of this module so I can finish out this pull request. Sorry this has taken so long... Thanks for your help! |
@geoffreyfloyd - Did you see above? I can't test this PR without a sample file, so I'll close this if I don't hear back. Thanks again for your help either way! |
Hi drj-io, I try to re-open this bug. Also me found this problem in Audition. I can send you the audio files do you want. Let me know if you have a repository where I can put the audio files. |
Hi, I spend time looking for this fix. I tried with a junk wav file and give me an error with the main branch Ps, this is a zip because github don't allow uploading wav file directly. Looking forward for this merge request :) Thanks for such a work 👍 |
Hi, finally I have made a pull request that handle JUNK files correcly and other useful improvements to this great lib. Bext file example: (I have a github error because the file is 35MB so uploaded to my server) |
The WAV files created by Adobe Audition include a 'JUNK' chunk that comes before the 'fmt' chunk, so code was added to recognize the JUNK chunk, move past it, and properly continue with the expected fmt chunk.