Skip to content

Commit

Permalink
ci: tests against redis gem v5 (#612)
Browse files Browse the repository at this point in the history
* ci: tests against redis gem v5

* ci: fixes incompatibility between redis-store 1.9.2 and redis 5
  • Loading branch information
grzuy authored Jul 25, 2023
1 parent c8e574a commit e039ecd
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
- rails_4_2
- dalli3
- dalli2
- redis_5
- redis_4
- redis_3
- connection_pool_dalli
- active_support_redis_cache_store
- active_support_redis_cache_store_pooled
Expand Down
13 changes: 7 additions & 6 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ appraise 'dalli3' do
gem 'dalli', '~> 3.0'
end

appraise 'redis_4' do
gem 'redis', '~> 4.0'
appraise 'redis_5' do
gem 'redis', '~> 5.0'
end

appraise 'redis_3' do
gem 'redis', '~> 3.3'
appraise 'redis_4' do
gem 'redis', '~> 4.0'
end

appraise "connection_pool_dalli" do
Expand All @@ -64,13 +64,13 @@ end

appraise "active_support_redis_cache_store" do
gem "activesupport", "~> 6.1.0"
gem "redis", "~> 4.0"
gem "redis", "~> 5.0"
end

appraise "active_support_redis_cache_store_pooled" do
gem "activesupport", "~> 6.1.0"
gem "connection_pool", "~> 2.2"
gem "redis", "~> 4.0"
gem "redis", "~> 5.0"
end

appraise "redis_store" do
Expand All @@ -79,4 +79,5 @@ end

appraise "active_support_redis_store" do
gem "redis-activesupport", "~> 5.0"
gem 'redis-store', '1.9.1' # remove after https://github.com/redis-store/redis-store/issues/358 is resolved
end
2 changes: 1 addition & 1 deletion gemfiles/active_support_redis_cache_store.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
source "https://rubygems.org"

gem "activesupport", "~> 6.1.0"
gem "redis", "~> 4.0"
gem "redis", "~> 5.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/active_support_redis_cache_store_pooled.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

gem "activesupport", "~> 6.1.0"
gem "connection_pool", "~> 2.2"
gem "redis", "~> 4.0"
gem "redis", "~> 5.0"

gemspec path: "../"
1 change: 1 addition & 0 deletions gemfiles/active_support_redis_store.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
source "https://rubygems.org"

gem "redis-activesupport", "~> 5.0"
gem "redis-store", "1.9.1"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/redis_3.gemfile → gemfiles/redis_5.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

source "https://rubygems.org"

gem "redis", "~> 3.3"
gem "redis", "~> 5.0"

gemspec path: "../"

0 comments on commit e039ecd

Please sign in to comment.