Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [ZNO-2042] add analytical DB (clickhouse) #9

Merged
merged 1 commit into from
Sep 29, 2023
Merged

feat: [ZNO-2042] add analytical DB (clickhouse) #9

merged 1 commit into from
Sep 29, 2023

Conversation

dkaliberda
Copy link
Collaborator

@dkaliberda dkaliberda commented Sep 29, 2023 •
edited
Loading

SUMMARY

Added analytical database (clickhouse)

TESTING INSTRUCTIONS

  • open path /databaseview/list/
  • you should see the "clickhouse" database
  • the database connection test must be successful

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Sep 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

NikolayBorovenskiy
NikolayBorovenskiy requested changes Sep 29, 2023
View reviewed changes
docker-compose-non-dev.yml Show resolved Hide resolved
docker-compose-non-dev.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker/.env Outdated Show resolved Hide resolved
@NikolayBorovenskiy
Copy link

@dkaliberda Please fix pre-commit CI.

@dkaliberda dkaliberda force-pushed the dkaliberda/clickhouse-integation branch from fb7c670 to 7a3002b Compare September 29, 2023 15:56
@dkaliberda dkaliberda changed the title feat: [ZNO-20421] add analytical DB (clickhouse) feat: [ZNO-2042] add analytical DB (clickhouse) Sep 29, 2023
@NikolayBorovenskiy NikolayBorovenskiy merged commit dc90b68 into zno-project Sep 29, 2023
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@NikolayBorovenskiy NikolayBorovenskiy NikolayBorovenskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkaliberda @NikolayBorovenskiy