Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [MON-5091] superset base branding #24

Merged
merged 1 commit into from
May 16, 2024
Merged

feat: [MON-5091] superset base branding #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docusaurus.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const config = {
navbar: {
logo: {
alt: 'Superset Logo',
src: '/img/superset-logo-horiz.svg',
src: '/img/superset-logo-horiz.png',
srcDark: '/img/superset-logo-horiz-dark.svg',
},
items: [
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ export default function Home(): JSX.Element {
const navbar = document.body.querySelector('.navbar');
const logo = document.body.querySelector('.navbar__logo img');
navbar.classList.remove('navbar--dark');
logo.setAttribute('src', '/img/superset-logo-horiz.svg');
logo.setAttribute('src', '/img/superset-logo-horiz.png');
};

// Set up dark <-> light navbar change
Expand Down
Binary file modified superset-frontend/src/assets/images/favicon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified superset-frontend/src/assets/images/superset-logo-horiz.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion superset-frontend/src/assets/stylesheets/antd/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
/*
Theme variables here: https://github.com/ant-design/ant-design/blob/master/components/style/themes/default.less
*/
@primary-color: #e62050;
@primary-color: #2b47ff;
@info-color: #66bcfe;
@success-color: #59c189;
@processing-color: #66bcfe;
Expand Down
16 changes: 8 additions & 8 deletions superset-frontend/src/assets/stylesheets/less/variables.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@
/* component styles. This will allow us to more easily adjust theming */
/************************************************************************/

@primary-color: #e62050;
@primary-color: #2b47ff;
@indicator-color: @primary-color;

@brand-primary-dark1: #c1163f;
@brand-primary-dark2: #991132;
@brand-primary-light1: #f1839e;
@brand-primary-light2: #f7b4c4;
@brand-primary-light3: #fce7ec;
@brand-primary-light4: #fce7ec;
@brand-primary-light5: #fce7ec;
@brand-primary-dark1: darken(@primary-color, 10%);
@brand-primary-dark2: darken(@primary-color, 20%);
@brand-primary-light1: lighten(@primary-color, 5%);
@brand-primary-light2: lighten(@primary-color, 10%);
@brand-primary-light3: lighten(@primary-color, 15%);
@brand-primary-light4: #dae9ff;
@brand-primary-light5: lighten(@primary-color, 25%);

@brand-secondary: #444e7c;
@brand-secondary-dark1: #363e63;
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/features/home/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ const StyledHeader = styled.header`
.ant-menu-item a {
&:hover {
color: ${theme.colors.grayscale.dark1};
background-color: ${theme.colors.primary.light5};
background-color: transparent;
border-bottom: none;
margin: 0;
&:after {
Expand Down
18 changes: 9 additions & 9 deletions superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
APP_NAME = "Superset"

# Specify the App icon
APP_ICON = "/static/assets/images/superset-logo-horiz.svg"
APP_ICON = "/static/assets/images/superset-logo-horiz.png"

# Specify where clicking the logo would take the user
# e.g. setting it to '/' would take the user to '/superset/welcome/'
Expand Down Expand Up @@ -596,14 +596,14 @@ class D3Format(TypedDict, total=False):
THEME_OVERRIDES = {
"colors": {
"primary": {
"base": "#e62050",
"dark1": "#c1163f",
"dark2": "#991132",
"light1": "#f1839e",
"light2": "#f7b4c4",
"light3": "#fce7ec",
"light4": "#fce7ec",
"light5": "#fce7ec",
"base": "#2b47ff",
"dark1": "#2141e6",
"dark2": "#1831cc",
"light1": "#3456ff",
"light2": "#406eff",
"light3": "#4b84ff",
"light4": "#dae9ff",
"light5": "#60b2ff",
}
}
}
Expand Down
Loading