Core: Throw TypeError instead of Error for invalid test.each() dataset

qunitjs · Sep 5, 2024 · 0231379 · 0231379
1 parent ec7d6e7
commit 0231379
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/test.js b/src/core/test.js
@@ -38,7 +38,7 @@ export default function Test (settings) {
   // - 2: QUnit.test
   // - 3: user file
   //
-  // This needs is customised by test.each()
+  // A notable exception is test.each(), which overrides this.
   this.stackOffset = 3;
   extend(this, settings);
 
@@ -939,7 +939,7 @@ function runEach (data, eachFn) {
       eachFn(data[key], key);
     }
   } else {
-    throw new Error(
+    throw new TypeError(
       `test.each() expects an array or object as input, but
 found ${typeof data} instead.`
     );

diff --git a/test/main/each.js b/test/main/each.js
@@ -11,7 +11,7 @@ QUnit.module('test.each', function () {
   QUnit.test.each('test.each fails with non-array input', ['something', 1, undefined, null], function (assert, value) {
     assert.throws(function () {
       QUnit.test.each('test.each 1D', value, function () { });
-    });
+    }, TypeError);
   });
 
   // Promise support for test.each() is tested in test/main/promise.js.